Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMS standard: https://datatracker.ietf.org/doc/html/rfc5652 #47

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

ancwrd1
Copy link
Contributor

@ancwrd1 ancwrd1 commented Sep 29, 2021

This PR adds CMS (a.k.a. PKCS#7) data types used with S/MIME messaging.

Copy link
Collaborator

@XAMPPRocky XAMPPRocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! This mostly looks good to me I have a couple of things.

  • Can we add some documentation to the types instead of comments showing the ASN.1 syntax? I think that would be more useful.
  • What would you think about having this as pub mod cms; module in the PKIX crate similar to EST?

standards/cms/src/lib.rs Outdated Show resolved Hide resolved
@XAMPPRocky
Copy link
Collaborator

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 764129c into librasn:main Sep 30, 2021
@XAMPPRocky
Copy link
Collaborator

I've now published this on crates.io https://docs.rs/rasn-cms

This was referenced Jul 11, 2023
This was referenced Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants